Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip characters from stdbounties_id and check isdigit #1973

Merged
merged 1 commit into from
Aug 9, 2018

Conversation

mbeacom
Copy link
Contributor

@mbeacom mbeacom commented Aug 9, 2018

Description

The goal of this PR is to clean the provided standard bounties ID and ensure it's a digit before attempting to filter the QS by the provided value.

Checklist
  • linter status: 100% pass
  • changes don't break existing behavior
  • commit message follows commit guidelines
Affected core subsystem(s)

bounty details

Testing

Locally

Refers/Fixes

Fixes #1972

@mbeacom mbeacom added backend This needs backend expertise. bounties labels Aug 9, 2018
@mbeacom mbeacom self-assigned this Aug 9, 2018
@codecov
Copy link

codecov bot commented Aug 9, 2018

Codecov Report

Merging #1973 into master will increase coverage by <.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1973      +/-   ##
==========================================
+ Coverage   25.47%   25.48%   +<.01%     
==========================================
  Files         130      130              
  Lines       10740    10744       +4     
  Branches     1433     1433              
==========================================
+ Hits         2736     2738       +2     
- Misses       7926     7928       +2     
  Partials       78       78
Impacted Files Coverage Δ
app/dashboard/views.py 15% <33.33%> (-0.03%) ⬇️
app/app/utils.py 19.68% <66.66%> (+0.74%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e72d86...00adce7. Read the comment docs.

Copy link
Member

@thelostone-mc thelostone-mc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@thelostone-mc thelostone-mc merged commit c06efe7 into master Aug 9, 2018
@thelostone-mc thelostone-mc deleted the fix-1972 branch August 9, 2018 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend This needs backend expertise. bounties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants